[PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

Erich Hoover ehoover at mines.edu
Mon Jan 17 14:28:30 CST 2011

On Sun, Jan 16, 2011 at 1:01 PM, Jacek Caban <jacek at codeweavers.com> wrote:
> On 1/15/11 12:14 AM, Erich Hoover wrote:
>> ...
>> +    hres = IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&target);
> document may be NULL here.

Sorry, I'll take care of that.

>> +    hres = IOleCommandTarget_Exec(target, NULL, cmdID, cmdexecopt, pvaIn, pvaOut);
> Please write a test case for this. MSDN seems wrong in this case. It indicates in one place that we should use CGID_MSHTML as group GUID, and NULL in the other. The test should make it clean, which version is true.

I've looked into trying to do this test case and I'm at a bit of a
loss.  It appears that whatever I try to do the "webbrowser" tests
hijack the IOleCommandTarget, so I'm not really testing what the
"real" target does.  It instead calls the test-specific
OleCommandTarget_QueryStatus, though that test does not report any
error on the ever-so-significant line:
ok(!pguidCmdGroup, "pguidCmdGroup != MULL\n");

On a side note, do I need to resend the other two patches in that set?
 They are not dependent on this patch.

Erich Hoover
ehoover at mines.edu

More information about the wine-devel mailing list