[PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

Erich Hoover ehoover at mines.edu
Wed Jan 19 14:31:04 CST 2011


On Wed, Jan 19, 2011 at 1:05 PM, Jacek Caban <jacek at codeweavers.com> wrote:
> On 1/18/11 7:31 PM, Erich Hoover wrote:
> >   I've attached a test where I disabled the client/container, and you
> > can see that it then gets passed through (QueryStatusWB will return
> success instead of passing through the client target and returning
> failure):
> > https://testbot.winehq.org/JobDetails.pl?Key=8408
>
> Hmm, it means that another run of tests (at least required subset of
> existing test_WebBrowser) with client's IOleCommandTarget disabled would
> be interesting. Do you feel like writing it? Otherwise we'd need at  least
> a FIXME in this case.

I've been working on putting such a test together, I actually just
finished it up when I got your message.  It's attached to this email,
and I would appreciate it if you would take a look - it ends up being
rather non-trivial since native caches the IOleCommandTarget on
creation of the container.

Corresponding test results:
https://testbot.winehq.org/JobDetails.pl?Key=8449

Erich Hoover
ehoover at mines.edu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: QueryStatusTest.diff
Type: text/x-patch
Size: 11348 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110119/e2b2e0a8/attachment.bin>


More information about the wine-devel mailing list