[PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

Erich Hoover ehoover at mines.edu
Thu Jan 20 11:40:59 CST 2011

On Thu, Jan 20, 2011 at 4:00 AM, Jacek Caban <jacek at codeweavers.com> wrote:
> ...
> +    ok(status&  success_flag, "OLECMDID_STOP not enabled/supported: %08x\n", status);
> You could test the exact value here: ok(status == ...)

I was trying to avoid adding some conditional todo_wine calls (for
some reason native does not respond with "supported", even though it
does in the mshtml tests), please see if you like the attached better.

> test_CommandTargetPassthru(TRUE) could go to existing test_WebBrowser.

Would it not be better to just keep these all in one place, since for
the tests without the custom target it's necessary to create and
initialize a web-browser?

> +    if (!target)
> +        return E_FAIL;
> A test for this case would be nice. Also with this patch, testing ExecEB shouldn't be too hard, let's test it as well.

Ugg, apparently MSDN lies horribly - it's actually E_UNEXPECTED.
Please check the attached for both.

Corresponding test results:

Thanks for all your feedback!

Erich Hoover
ehoover at mines.edu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CommandPassthruTest.diff
Type: text/x-patch
Size: 14630 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110120/b0acde9a/attachment.bin>

More information about the wine-devel mailing list