windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

[Damjan Jovanovic]

On Fri, Jan 21, 2011 at 10:52 AM, Reece Dunn <msclrhd at googlemail.com> wrote:

> On 21 January 2011 08:36, Damjan Jovanovic <damjan.jov at gmail.com> wrote:
> > Should we reconsider libicns? Apple's APIs obviously can't be relied
> upon.
>
> You could always:
>
> 1.  check for native support (including presence of
> kIconServices16PixelDataARGB) and use if present;
> 2.  check for libicns and use it if present;
> 3.  disable ICNS support.
>
> using autoconf checks. That way, support is enabled where available
> (instead of relying on OS version detection logic).
>
> NOTE: the libicns check is optional as it would require maintaining
> both native OSX and libicns versions.
>
> - Reece
>

About option 3:

December 2010 desktop OS market share, Wikimedia stats:
Intel MacOS X 10.4   0.49%
Ubuntu 10.10   0.25%
Ubuntu 10.04   0.34%.

If distribution of Wine users among Linux and MacOS is roughly equal, then
even if we disable icons on only Intel MacOS X 10.4, it will break for
almost as many users as are using Ubuntu 10.04 and 10.10 put together.

Damjan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110121/7adfe8b2/attachment.htm>