PATCH: User32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*

Vitaliy Margolen wine-devel at kievinfo.com
Fri Jan 28 09:11:06 CST 2011


On 01/27/2011 11:51 PM, Alexander LAW wrote:
>
>
> +        if (style & WS_VISIBLE) {
> +			HDC hdc = GetDC(hWnd);
> +			HBRUSH hbrush;
> +			RECT client, rc;
> +			HWND parent = GetParent(hWnd);

Please follow the style of the file - curly brace goes on a separate line.

Please if you can't set your editor to have tab character equal 8 spaces - 
don't use tabs! Use space characters only.

> +			if (!parent) parent = hWnd;
> +			UINT  ctlMessage=((btn_type==BS_PUSHBUTTON ||
> btn_type==BS_DEFPUSHBUTTON || btn_type==BS_PUSHLIKE)?WM_CTLCOLORBTN:
> WM_CTLCOLORSTATIC);

This is not c++ inline declarations are not allowed.
Please cut this line down it's too long.

Also please add corresponding test to msg.c tests to validate the change.

Vitaliy.



More information about the wine-devel mailing list