[PATCH 2/2] mshtml: Mark some functions as cdecl.

[Jacek Caban]

On 7/7/11 6:02 PM, Juan Lang wrote:
> Hi Jacek,
>
>> These are functions that I missed when revieweing Gecko headers. I will
>> probably change their calling convention in the next Gecko release.
> In that case, why not change the calling convention now?  The matrix
> of possible configurations is much simpler that way.
>
> Right now, we have:
> current Wine + current gecko = crash
>
> By changing the calling convention in Wine, we have:
> Wine<= 1.3.23 + current gecko = crash
> Wine 1.3.24-?? + current gecko = no crash
> Wine ?? + current gecko = crash
> Wine ?? + new gecko = no crash
> Wine<= 1.3.23 + new gecko = crash
>
> By doing a new gecko release, we have:
> any Wine + current gecko = crash
> any Wine + new gecko = no crash
>

There is 1:1 mapping between Gecko and Wine version. You won't be able 
to use current Wine with the new Gecko nor future Wine with current 
Gecko. And doing Gecko release is quite not that simple to do it for 
such a minor change.

BTW, the current plan is to do the new Gecko release together with 
Firefox 6 release, which is about 6 weeks from now. The first beta 
version should be out in a week or two, depending on how Firefox beta 
will behave.

Jacek