d3dx9_36: Push down the scope of two variables. (RESEND)

Gerald Pfeifer gerald at pfeifer.com
Tue Jul 5 13:33:49 CDT 2011

On Tue, 5 Jul 2011, Alexandre Julliard wrote:
>> This does not fix a bug or add a feature, but it makes the coder easier
>> to follow.  Narrower scope tends to be a good thing for variables, both
>> for human readers and compilers (though modern ones should not need the
>> hint).
> Not necessarily, that's a matter of taste (IOW, not something you should
> "fix" in other people's code).

The reason I came up with this patch is that trying to debug something
I got lost a bit, and reducing the scope of these variables really helped
make things easier to follow.

When you are referring to "other people's code", according to git log 
Tony has been the primary contributor, so that would be his call then?

Tony, this is 
-- what's your take?


More information about the wine-devel mailing list