d3d8/tests: make sure to use return values (LLVM/Clang)

Jacek Caban jacek at codeweavers.com
Tue Jul 26 10:33:54 CDT 2011

On 07/26/11 17:22, Henri Verbeet wrote:
> On 26 July 2011 16:57, Jacek Caban <jacek at codeweavers.com> wrote:
>> Seriously, I'm not talking about anything like that. We get to choose
>> between using two things. SUCCEDEED() has no advantages over testing
>> exact values in this context. Testing the exact value has a small, but
>> still, advantage. I believe we agree on this. Then if you have a choice,
> No, I disagree with the basic idea that stricter tests are necessarily
> better. The advantage of SUCCEEDED is that it's *less* strict.

We won't agree on that.

> That said, the specific issue is insignificant enough that I wouldn't
> care about e.g. a new test using "hr == D3D_OK". I just don't think
> that changing existing tests from SUCCEEDED to "hr == D3D_OK" is
> really an improvement.

Well, I didn't say anything about changing existing code and I didn't
even try to reject a patch because of that. I was commenting a new code
that had to be resent to wine-patches anyway, so I don't know what was
the discussion about...


More information about the wine-devel mailing list