[PATCH 1/4] Check for null pointers before strcmp. (LLVM/Clang)

[Juan Lang]

> It would be a lot easier to find and fix real things if there weren't a
> thousand false ones hanging around. But if you feel it's better to have a
> lot of warnings and some possible bugs than a lot of checks and no bugs,
> then maybe I'll not waste any more time "fixing" them.

This is a false dichotomy.  LLVM/Clang uses static analysis, which is
a sound technique, i.e. it produces no false negatives.  The downside
is that it will always produce false positives.  Filtering out false
positives is a necessary component of any bug fixing exercise using
static analysis.  I'd argue that this is one such example, that the
fix isn't worth the noise, as there's no actual bug being fixed.
--Juan