[PATCH 2/2] d3dx9/line: Implemented tests for ID3DXLine's Begin and End methods.

Matteo Bruni matteo.mystral at gmail.com
Mon Jun 20 08:20:03 CDT 2011

2011/6/18 Charles Welton <charleswfb at gmail.com>:
> ---
>  dlls/d3dx9_36/tests/line.c |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
> +    srand(time(NULL));
> +    random = ((FLOAT) rand())/RAND_MAX; /* Random value between 0.0 and 1.0. We're using this later. */

I didn't check why your patch failed with the testbot. Nevertheless,
you should avoid to use random values: the tests should be repeatable.
Just pick some arbitrary values and use them. Also, for better
clarity, you may want to use a different variable for the modified
identity matrix (because, at that point, it isn't identity anymore).
Maybe you could check the world matrix between ID3DXLine_Begin and
ID3DXLine_End too.

More information about the wine-devel mailing list