[PATCH 3/3] mshtml: Added support for indexed access to form elements

Jacek Caban jacek at codeweavers.com
Thu Mar 3 07:55:32 CST 2011

On 3/3/11 2:45 PM, Alexandre Julliard wrote:
> Jacek Caban<jacek at codeweavers.com>  writes:
>> +    /* FIXME: Implement in more generic and safe way */
>> +    for(ptr = name; *ptr&&  isdigitW(*ptr); ptr++)
>> +        i = i*10 + (*ptr-'0');
> What's wrong with strtoulW?

We don't want to use strings like "+1" or with leasing spaces for 
indexed access. The comment was more about considering moving it to 
IDispatchEx implementation layer than parsing itself. BTW, it's a really 
broken design of IDispatchEx. When a scripts accesses property by 
integer index, the integer is converted to string and passed to 
GetDispID, which parses it back.


More information about the wine-devel mailing list