winex11: Quite a noisy FIXME

Andrew Nguyen anguyen at codeweavers.com
Sat Mar 12 13:20:26 CST 2011


On 03/12/2011 01:10 PM, André Hentschel wrote:
> Yeah i know the fixme has good reasons, but still it shouldn't mess on console.
> ---
>  dlls/winex11.drv/xrender.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c
> index fde0b91..70fd5e2 100644
> --- a/dlls/winex11.drv/xrender.c
> +++ b/dlls/winex11.drv/xrender.c
> @@ -2435,7 +2435,9 @@ void X11DRV_XRender_UpdateDrawable(X11DRV_PDEVICE *physDev)
>  BOOL XRender_AlphaBlend( X11DRV_PDEVICE *devDst, X11DRV_PDEVICE *devSrc,
>                           struct bitblt_coords *dst, struct bitblt_coords *src, BLENDFUNCTION blendfn )
>  {
> -  FIXME("not supported - XRENDER headers were missing at compile time\n");
> +  static int once;
> +  if(!once)
> +    FIXME("not supported - XRENDER headers were missing at compile time\n");
>    return FALSE;
>  }
>  

Since the static variable once is never incremented, the if condition is
practically a no-op.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110312/8e78f8bc/attachment.pgp>


More information about the wine-devel mailing list