[PATCH 2/4] comdlg32: Add stub implementation of the Common Item dialogs.

David Hedberg david.hedberg at gmail.com
Tue Mar 22 16:43:58 CDT 2011

>> On Mon, Mar 21, 2011 at 14:55, Nikolay Sivov<bunglehead at gmail.com>  wrote:
> I think it is, it makes it clear that dialogue instance is about save or
> open, not both.

Ok, I'll change that.

> By the way, IFileSaveDialog is based on IFileDialog, and you add
> IFileDialog2 too. It's a bit messy,
> does target class object that will use FileDialogImpl really respond to
> IFileDialog2?

I'm not completely sure I understand the question, but the same thing
goes for the IFileOpenDialog. I just rechecked on Windows 7, and both
the IFileSaveDialog and the IFileOpenDialog can be successfully
queried for the IFileDialog2 interface. There are tests for that in
the test patch I sent, sort of, although the E_NOINTERFACE case is
merely marked as broken for the sake of Vista.

More information about the wine-devel mailing list