[1/2] uxtheme: Add OpenThemeDataEx (try 2)

Dmitry Timoshkov dmitry at codeweavers.com
Wed Mar 23 12:00:36 CDT 2011


André Hentschel <nerv at dawncrow.de> wrote:

> Applied Dmitry's suggestions

> -HTHEME WINAPI OpenThemeData(HWND hwnd, LPCWSTR pszClassList)
> +HTHEME WINAPI OpenThemeDataEx(HWND hwnd, LPCWSTR classlist, DWORD flags)
>  {
> -    WCHAR szAppBuff[256];
> -    WCHAR szClassBuff[256];
> -    LPCWSTR pszAppName;
> -    LPCWSTR pszUseClassList;
> +    WCHAR appbuff[256];
> +    WCHAR classbuff[256];
> +    LPCWSTR appname;
> +    LPCWSTR useclasslist;
>      HTHEME hTheme = NULL;

You are changing too much. Just use lowercase named variables for new code,
not touching existing ones.

> -    TRACE("(%p,%s)\n", hwnd, debugstr_w(pszClassList));
> +    TRACE("(%p,%s, %u)\n", hwnd, debugstr_w(classlist), flags);

flags above is still printed in decimal.

> +
> +    if(flags)
> +        FIXME("unhandled Flags: %x\n", flags);

-- 
Dmitry.



More information about the wine-devel mailing list