[2/2] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load().

[Nikolay Sivov]

On 5/4/2011 19:30, Adam Martinson wrote:
> On 05/03/2011 05:30 PM, Nikolay Sivov wrote:
>> I'm worried about VT_UI1 being interpreted as ASCII stream or just a 
>> byte stream that could be in any encoding. If it's a case you can't 
>> assume it's encoded as utf8, when you do utf8 -> utf16 (for BSTR).
>>
>> For this particular case you might want direct doparse() call for 
>> VT_UI1 array, I suggest a simple test -- create byte (VT_UI1) array 
>> over a WCHAR buffer with UTF16 xml data and try to ::load() from it. 
>> If encoding is detected then you need direct doparse() call, to do 
>> completely clear case don't include encoding= attribute in this xml 
>> data.
> I glad you mentioned this, I thought about that too.  I did some 
> testing and it seems that only UTF8 (or maybe just ASCII) is 
> supported.  The SAFEARRAY does seem to be treated more like a file 
> than a string, eg if there is a '\0' at the end of the array it causes 
> a parse error (I don't think we need to duplicate that behavior though).
Yeah, I don't see a reason to implement this particular case for now.
>   I'm not sure if multi-dimensional arrays are supported, it will take 
> some further testing, but if so that can be a separate patch; for now 
> I'll just add a FIXME if the array is not a vector.
I don't expect it's supported, it sounds a bit insane for me to load 
from multidimensional arrays. I think after this case (VT_UI1 array) 
implemented we need a WARN for any other variant type. And some tests 
for sure.