[PATCH] msi: Fixed check_flag_combo macro (Coverity)

Alexandre Julliard julliard at winehq.org
Mon May 9 05:07:39 CDT 2011


Marcus Meissner <meissner at suse.de> writes:

> The macro was always FALSE, as
> 	x & y == ~y
> is always FALSE. x& y == y was clearly intended.
> CID 1448

It doesn't work here:

../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok
action.c:5578: Test failed: Expected ERROR_SUCCESS, got 1627
action.c:5587: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0
action.c:5599: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0
action.c:5656: Test failed: key not created
action.c:5660: Test failed: key not created
action.c:5664: Test failed: key not created
make: *** [action.ok] Error 6

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list