comctl32/listview: Make edit box handle available from LVN_ENDLABELEDIT notification
Vitaliy Margolen
wine-devel at kievinfo.com
Mon May 9 08:39:57 CDT 2011
On 05/09/2011 01:09 AM, Nikolay Sivov wrote:
> Fix for http://bugs.winehq.org/show_bug.cgi?id=25908
>
There are 3 separate changes in this patch:
> - BOOL bSame;
> + BOOL same;
Variable name rename.
The actual fix with new test.
> + ok(g_editbox_disp_info.item.pszText != NULL, "got %p\n", g_editbox_disp_info.item.pszText);
Btw it's nice to print what did you expected back.
> + ok(!IsWindow(hwndedit), "Expected Edit window to be freed\n");
I'm not so sure you can rely on system not allocating any more windows with
the same handle. This is a race condition.
> - /* WM_COMMAND with EN_KILLFOCUS isn't forwared to parent */
> + /* WM_COMMAND with EN_KILLFOCUS isn't forwarded to parent */
A typo fix.
Vitaliy.
More information about the wine-devel
mailing list