ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.

Alexandre Julliard julliard at winehq.org
Thu Nov 17 06:41:09 CST 2011

Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>> >> > The tests clearly show that this commit is wrong. If there is an application
>> >> > or a test case which fails because of this, it would be helpful to at least
>> >> > mention it.
>> >> 
>> >> It fixes the test for .bss protection, in ntdll:info.c.
>> >
>> > I don't see that test failing before that commit or after the revert.
>> It fails with PE binaries but not Unix ones.
> So the test doesn't really exist? Why do you think that a failure you see
> is a loader thing and not something that happens at run-time? Please add
> a real test and I'll have a look.

The test requires a PE binary because obviously we can't test PE
protections on Unix binaries. That doesn't mean it doesn't exist. Just
build a crosstest:

$ wine ntdll_crosstest.exe info.c
info.c:1296: Test failed: mbi.Protect is 0x8, expected 0x4

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list