dinput: Stub IDirectInputJoyConfig8 interface.

Michael Stefaniuc mstefani at redhat.com
Thu Nov 24 13:27:06 CST 2011


Hello Vitaliy,

On 11/24/2011 06:28 PM, Vitaliy Margolen wrote:
> ---
>  dlls/dinput/dinput_main.c    |    7 ++
>  dlls/dinput/dinput_private.h |    2 +
>  dlls/dinput/joystick.c       |  195 +++++++++++++++++++++++++++++++++
>  include/dinputd.h            |  243 ++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 447 insertions(+), 0 deletions(-)
>  create mode 100644 include/dinputd.h

we are trying to get rid off the LPJUNK,
IDirectInputJoyConfig8 * is so much more nicer than LPDIRECTINPUTJOYCONFIG8.

While the above is more of a nit-pick (and an easy search and replace
patch for me) the QueryInterface implementation is not correct:
- Query for IID_IUnknown is not supported.
- Use IDirectInputJoyConfig8_AddRef() on the interface without the cast
- You can save the round trip over impl_from_IDirectInputJoyConfig8() as
iface and &This->IDirectInputJoyConfig8_iface are the exact same thing.

bye
	michael




More information about the wine-devel mailing list