[PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.

Henri Verbeet hverbeet at gmail.com
Fri Nov 25 13:23:01 CST 2011

On 25 November 2011 19:50, Stefan Dösinger <stefandoesinger at gmx.at> wrote:
> Am Donnerstag, 24. November 2011, 22:52:32 schrieb Henri Verbeet:
>> +    if (surface->flags & SFLAG_CONVERTED)
>> +    {
>> +        ENTER_GL();
>> +        glEnable(textype);
>> +        checkGLcall("glEnable(textype)");
>> +        LEAVE_GL();
>> +        return WINED3D_OK;
>> +    }
> I don't think this is correct. E.g. signed formats without
> GL_NV_texture_shader have load time and read time fixups and both have to be
> applied.
That's silly. If that's really the case that should be fixed. Note
that this case would already be broken with the current code though,
arbfp_blit_set() only handles P8 and the various YUV fixups. More
generally, I have some doubts about whether the way converted surfaces
currently work is really what we want.

> What exactly are you trying to fix? I assume it is something about P8 blits,
> but P8->P8 blits don't enter the ARB blitting code(due to the dest fixup
> check), and I don't know of any app that uses P8->RGB or SNORM->UNORM blits.
P8 -> RGBA.

More information about the wine-devel mailing list