[1/4] winscard: implementation

Stefan Leichter Stefan.Leichter at camline.com
Thu Oct 6 13:13:05 CDT 2011

Am Donnerstag 06 Oktober 2011, 16:07:29 schrieb Bruno Jesus:
> 2011/10/3 André Hentschel <nerv at dawncrow.de>:
> > Am 03.10.2011 09:31, schrieb Vincent Hardy:
> >> First submitted on wine-devel and modified following comments from Marcus Meissner (MAX_ATR_SIZE / bytecount).
> >>
> >
> > OK, some notes:
> > "winscard: implementation" is a very bad name for a patch, especially for 4.
> > Splitting the patches is a good idea, but you need to split it different (you are adding dead code).
> > In the first patch you might want to add the configure.ac and library loading stuff together with only the things needed for e.g. SCardListReadersA (why no SCardListReadersW?) and then e.g. a patch for every new function.
> > I didn't looked at the code, but i want to remember you to read http://wiki.winehq.org/SubmittingPatches
> Hi to all, I would like to help Vincent to get this patches in. But we
> need more objective help. The comments in this email and in previous
> Vincent email differ. One says "send small patch" the other says "send
> full functionality patch series". I would like to restart this thread
> because otherwise it will be forgotten together with the patches.
> This is a whole new feature, in my short period into wine developing
> this is the first time I see a completely new thing being introduced.

have a look at http://www.winehq.org/pipermail/wine-devel/2007-May/057057.html . There you find the reason why the patches did not go  in the first time.

Bye Stefan

More information about the wine-devel mailing list