jscript: Mark some fall-throughs in switch statements
Bruno Jesus
00cpxxx at gmail.com
Sat Oct 8 13:19:46 CDT 2011
On Sat, Oct 8, 2011 at 14:58, Alexandre Julliard <julliard at winehq.org> wrote:
> Andrew Talbot <andrew.talbot at talbotville.com> writes:
>
>> @@ -4037,6 +4037,7 @@ static HRESULT RegExpConstr_leftContext(script_ctx_t *ctx, vdisp_t *jsthis, WORD
>>
>> V_VT(retv) = VT_BSTR;
>> V_BSTR(retv) = ret;
>> + /* fall through */
>> }
>> case DISPATCH_PROPERTYPUT:
>> return S_OK;
>
> I don't think that PROPERTYGET is supposed to fall through to
> PROPERTYPUT.
>
Isn't it that way just to save the use of an extra return S_OK?
Instead a break could be used too because that function returns S_OK
by default.
http://source.winehq.org/source/dlls/jscript/regexp.c#L4025
Best regards,
Bruno
More information about the wine-devel
mailing list