[1/5] d3d8: Never announce support for palettized textures
hverbeet at gmail.com
Sun Oct 9 09:40:11 CDT 2011
On 9 October 2011 15:21, Stefan Dösinger <stefan at codeweavers.com> wrote:
> This is the first set of my P8 patches, they remove dead code that is left over
> from d3d8/9 style palettized texture support. See
> http://www.winehq.org/pipermail/wine-devel/2011-October/092744.html for the
> entire patchset.
I thought you asked me not to look at these patches yet because you
still had some issues to fix. Regardless, I gave this a cursory look:
- I can't say I find e.g. sprinkling d3dformat_is_palettized() over
the code particularly elegant.
- Do you have tests for the D3DERR_INVALIDCALL returns?
- In patch 5 you remove wined3d_device_get_current_texture_palette()
from the spec but not from the public header.
More information about the wine-devel