[1/4] wined3d: Use an rbtree for the blit programs
stefan at codeweavers.com
Wed Oct 12 06:22:59 CDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
Am 12.10.2011 um 11:57 schrieb Henri Verbeet:
> You already have the P8 shader.
My bad. What will actually be added is the NONE conversion with color keying. But adding a color keying flag is what makes the current approach unsustainable because it's orthogonal to the other properties.
> In the case of color keying it should
> probably at least be in the same series as the code that uses it,
I can resend the patch later, but IMO getting rid of the current spaghetti shader selection code makes sense on its own.
> I'm not sure an rbtree would really have a lot of advantages over a
> simple array there.
I chose the rbtree for consistency with the ffp and pshader/vshader selection, but an array is probably more efficient because I don't expect to have more than 4 different blit shaders at a time.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
-----END PGP SIGNATURE-----
More information about the wine-devel