[PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Sep 8 10:59:06 CDT 2011


Andrew Eikum asked:
>It would be nice to have tests for this,
>Are these part of the tests you're
>planning on submitting after you get the fixes in?
That is part of my tests, the latest testbot job is
https://testbot.winehq.org/JobDetails.pl?Key=14067
You can see that I still need to compute position estimates
based on the high performance timer as Sleep() is not accurate enough.

>and a fix for coreaudio if needed. Likewise for patch 2/2. 
The Mac never returns S_FALSE, so there was nothing to change.

I've yet another patch about IsFormatSupported in my queue,
but it needs more testing.
For instance, I've not yet tested inconsistent formats
(bad blockalign) or non PCM formats (e.g. A-law, ADPCM).
In short, it looks like IsFormatSupported simply
suggests GetMixFormat() in shared mode,
but would it suggest linear PCM when given A-law?

Regards,
	Jörg Höhle



More information about the wine-devel mailing list