[PATCH 1/9] cmd/tests: add tests for command line parsing

Frédéric Delanoy frederic.delanoy at gmail.com
Tue Sep 20 01:41:04 CDT 2011

2011/9/20 Frédéric Delanoy <frederic.delanoy at gmail.com>:
> On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck at arcor.de> wrote:
>> This patch adds some tests for command line parsing and treatment
>> of quotes and special characters in the command line and in program
>> names and parameters. The .exp file was created using Win XP.
>> ---
>>  programs/cmd/tests/rsrc.rc              |    6 +
>>  programs/cmd/tests/test_cmdline.cmd     |  159 ++++++++++++++++++++++
>>  programs/cmd/tests/test_cmdline.cmd.exp |  219 +++++++++++++++++++++++++++++++
>>  3 files changed, 384 insertions(+), 0 deletions(-)
>>  create mode 100755 programs/cmd/tests/test_cmdline.cmd
>>  create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp
> You might want to do a single "@echo off" at the start of the .cmd file.
> Echoing every command in the .exp isn't very helpful: you don't want
> to replicate the .cmd contents in the .exp file. Add comments or
> "subsections" as is done in test_builtins.cmd if necessary, or even
> better use descriptive results, like e.g. 'text in single quotes' if
> possible
> (Also the @ before every rem or echo just add visual clutter IMHO but
> that's due to the enabled echo mode)

Also, there should be no trailing whitespace.
See http://wiki.winehq.org/SubmittingPatches

More information about the wine-devel mailing list