[PATCH 1/9] cmd/tests: add tests for command line parsing

Frédéric Delanoy frederic.delanoy at gmail.com
Wed Sep 21 03:24:52 CDT 2011

2011/9/20 Martin Wilck <mwilck at arcor.de>:
> On 09/20/2011 01:24 AM, Frédéric Delanoy wrote:
>> You might want to do a single "@echo off" at the start of the .cmd file.
>> Echoing every command in the .exp isn't very helpful: you don't want
>> to replicate the .cmd contents in the .exp file.
> I did that on purpose. It makes figuring out problems *way* easier. I
> hate counting lines in the .exp file just to see which test was failing.

You don't need counting lines. Just put appropriate self-descriptive
messages + short test (sub)sections  Use echoing only for difficult
A shorter patch is easier to review and more auto-documenting.
The .exp file is not there for replicating the .cmd file, otherwise
the .cmd file wouldn't be needed in the first place...

Ex: (testing echo command here, but valid for all other commands)
@echo off [this line is generally not needed, unless echo mode was
previously activated]
echo ... quoted strings ...
echo 'single-quoted string'
echo "double-quoted string"
echo `backquoted string`
echo ... another subsection ...

... quoted strings...
'single-quoted string'
"double-quoted string"
`backquoted string`
... another subsection ...

> However, if that's a blocking point for getting the patches applied, it
> will be no problem to change that.

I'm not the one who commits patches, but they should be as concise as possible.
See http://wiki.winehq.org/SubmittingPatches

More information about the wine-devel mailing list