[PATCH 0/5] (4th attempt) CMD command line parsing

Frédéric Delanoy frederic.delanoy at gmail.com
Wed Sep 28 17:51:01 CDT 2011

On Thu, Sep 29, 2011 at 00:46, Martin Wilck <mwilck at arcor.de> wrote:
> This is my 4th attempt at fixing the cmd command line treatment.
> All patches pass the cmd tests with 0 errors both under wine and
> on the Test Bot, including NT. Whitespace issues are fixed, too.
> Apart from that, the code is the same as before.
> The size of my patches has been criticized - only patch 2/5 is
> really big, but it has to be that way to pass the tests.

It's just that the project leader, Alexandre Julliard, generally likes
patch as small as possible.
YMMV though, and if it's necessary to put it together, it's ok, just
indicate it as patch commit "comment" for AJ, if necessary

> This will also be my last attempt to get this merged.
> If the patches don't get applied this time, I hope that
> the cmd Gurus (Frederic or Dan) will take up the bits they
> like and get them in over time. If there are any technical issues
> or bugs in my code, I'll of course take care (please email me
> privately, as I'm not monitoring wine-devel).
> A private side note: I estimate that I have spent at least 10x more
> effort and time to get the tests right and the patches
> submission-ready than I spent on fixing the actual Wine code.

I think that's why Dan pointed that you should probably send a single
patch first to avoid reworking the whole series at once, to limit the
total amout of effort needed.

> I believe
> this project needs to think over its policies. I fully understand
> that a project this big needs to take a lot of care to maintain
> qualitiy standards. But the way this is currently working is
> discouraging and frustrating for casual contributors like myself.

Yes the "learning curve" is quite steep...
I've been bitten by this myself (and cmd test runner wasn't even
working properly when I began working on cmd...)
BTW if you had issues with the doc regarding patches
submissions/testbot (or other things), please tell so we can try to
fix that.

Anyway, thanks for your patches.
TBH I was a bit "scared" to see/fix how the whole quoting stuff is
done, after people told how horrific it was.
It's nice not to feel being left "alone in the dark" ;)

Now that the tests pass, you're just one step further on the way
towards patch application. Just need to pass through Alexandre's
filter ;)
(but since there's wineconf this w-e, there won't probably be any
commit rounds until next week)

> Martin Wilck (5):

More information about the wine-devel mailing list