gdi32: Constification.

Kusanagi Kouichi slash at ac.auone-net.jp
Thu Apr 5 07:37:58 CDT 2012


On 2012-04-04 17:35:58 +0200, Alexandre Julliard wrote:
> Kusanagi Kouichi <slash at ac.auone-net.jp> writes:
> 
> > @@ -6407,7 +6409,7 @@ static BOOL get_text_metrics(GdiFont *font, LPTEXTMETRICW ptm)
> >      return TRUE;
> >  }
> >  
> > -static BOOL face_has_symbol_charmap(FT_Face ft_face)
> > +static BOOL face_has_symbol_charmap(const FT_Face ft_face)
> >  {
> >      int i;
> >  
> > @@ -6729,7 +6731,7 @@ end:
> >  static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format,
> >                                         LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat )
> >  {
> > -    struct freetype_physdev *physdev = get_freetype_dev( dev );
> > +    const struct freetype_physdev * const physdev = get_freetype_dev( dev );
> >      DWORD ret;
> >  
> >      if (!physdev->font)
> 
> You are overdoing it. There's no reason to change per-value parameters
> or local variables like the physdev.

FT_Face is a typedef for struct FT_FaceRec_*, so it would be worth
adding const.



More information about the wine-devel mailing list