[PATCH 2/2] wininet/tests: Added checks for bad return values and skip tests when it happens. (try 2)

Alexandre Julliard julliard at winehq.org
Mon Apr 9 14:49:18 CDT 2012


Morten Rønne <morten.roenne at tdcadsl.dk> writes:

> Hi Alexandre
>
> Well if you do not get a ERROR_INSUFFICIENT_BUFFER back, then
> cbCacheEntryInfo will not be changed, and that means that using that
> value in a following HeapAlloc may cause different kind of problems.
> If cbCacheEntryInfo were zero, this will cause the following HeapAlloc
> to succesed, and return a pointer to a zero size buffer.

Leaving the function at that point is fine, my point was that the skip()
is unnecessary.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list