'Pending' patches state

Marcus Meissner marcus at jet.franken.de
Tue Apr 10 03:30:34 CDT 2012


On Tue, Apr 10, 2012 at 04:52:42PM +0900, Dmitry Timoshkov wrote:
> Jeff Latimer <lats at yless4u.com.au> wrote:
> 
> > I agree a lot of developers would benefit from feedback, however that
> > does not appear to be the Wine way of doing business.  Maybe a halfway
> > measure would be to automatically notify the developer that their patch
> > has been marked as pending and then the developer can ask.
> 
> Something like "Your patch is pending, you have to ask to get an answer why."?
> But the answer known, and it is
> * The patch is not obviously correct at first glance. Making a more
> convincing argument, preferably in the form of a test case, may help.
> * Waiting for feedback from the main developer in that area.
> 
> And how is that better than current situation when in order to get
> a feedback a developer have to ask?
> 
> Q: What's wrong with my patch xxx?
> A: The patch is not obviously correct at first glance...
> Q: What can I do?
> A: Making a more convincing argument, preferably in the form of a test case,
> may help.
> 
> ... or may not help.
> 
> http://wiki.winehq.org/SubmittingPatches suggests
> "If your patch disappears from http://source.winehq.org/patches/ without
> being committed, improve it (perhaps by adding more tests) and resend."
> 
> The patch disappears from the patch tracker in a month. You have plenty time
> for 11 resends in an year, don't you?

Also Alexandre to some parts comments on bad patches these days. :)

Ciao, Marcus



More information about the wine-devel mailing list