comdlg32: Resize Find dialog to fit translations

[Aurimas Fišeras]

2012.12.02 20:32, Dmitry Timoshkov rašė:
> Aurimas Fišeras <aurimas at gmail.com> wrote:
> 
>>>> Controls resized to fit translations for more languages. Tested with
>>>> resource editor.
>>>
>>> Did you see a comment in that file just before dialog templates?
>>>
>> Hello,
>> I obviously didn't notice that comment.
>>
>> Why do we have such a limitation?
> 
> Applications that use custom dialog templates and subclass the original
> ones (or rather the algorithm in comctl32 that resizes custom dialogs)
> depend on this .
> 
>> I checked the sizes of this dialog before conversion to po files [1] and
>> they were quite different between various languages.
> 
> If the dialog sizes differ from Windows templates - that's a bug and
> should be fixed.
> 
I see.

What about something like the attached patch? I resized both check boxes
and the direction group, positioned radio buttons in the direction group
one above the other.

I checked this dialog on Windows XP Lithuanian UI, and it had similar
differences from the English one.

-------------- next part --------------
From 7151dc5ce8a3bfa00010f47c6993ad3be7fd5a2d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aurimas=20Fi=C5=A1eras?= <aurimas at gmail.com>
Date: Sun, 2 Dec 2012 21:31:15 +0200
Subject: comdlg32: Move and resize controls of the Find dialog to better fit
 translations

---
 dlls/comdlg32/comdlg32.rc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/comdlg32/comdlg32.rc b/dlls/comdlg32/comdlg32.rc
index 7040fcc..7658e81 100644
--- a/dlls/comdlg32/comdlg32.rc
+++ b/dlls/comdlg32/comdlg32.rc
@@ -312,11 +312,11 @@ FONT 8, "MS Shell Dlg"
 {
  LTEXT "Fi&nd What:", -1, 4, 8, 52, 8
  EDITTEXT edt1, 57, 7, 148, 12, ES_AUTOHSCROLL | WS_BORDER | WS_GROUP | WS_TABSTOP
- CHECKBOX "Match &Whole Word Only", chx1, 4, 26, 120, 12, BS_AUTOCHECKBOX | WS_GROUP | WS_TABSTOP
- CHECKBOX "Match &Case", chx2, 4, 42, 120, 12, BS_AUTOCHECKBOX | WS_TABSTOP
- GROUPBOX "Direction", grp1, 127, 26, 78, 28
- CONTROL "&Up", rad1, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 131, 38, 35, 12
- CONTROL "&Down", rad2, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 163, 38, 35, 12
+ CHECKBOX "Match &Whole Word Only", chx1, 4, 26, 140, 12, BS_AUTOCHECKBOX | WS_GROUP | WS_TABSTOP
+ CHECKBOX "Match &Case", chx2, 4, 42, 140, 12, BS_AUTOCHECKBOX | WS_TABSTOP
+ GROUPBOX "Direction", grp1, 147, 21, 58, 38
+ CONTROL "&Up", rad1, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 151, 30, 48, 12
+ CONTROL "&Down", rad2, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 151, 44, 48, 12
 
  DEFPUSHBUTTON "&Find Next", IDOK, 212,  6, 60, 14, WS_GROUP | WS_TABSTOP | BS_DEFPUSHBUTTON
  PUSHBUTTON "Cancel", IDCANCEL	 , 212, 24, 60, 14, WS_GROUP | WS_TABSTOP
-- 
1.8.0