[PATCH] winmm: Don't mask out SND_ALIAS_ID or SND_FILENAME in sndPlaySound

Dmitry Timoshkov dmitry at baikal.ru
Wed Dec 5 10:14:53 CST 2012

Andrew Eikum <aeikum at codeweavers.com> wrote:

> > > The call is only supposed to return TRUE or FALSE, so I guess it's
> > > checking that the return value isn't 3 or something. Not very useful,
> > > sure, but it looked odd to just have a series of sndPlaySound calls in
> > > a row without ok() calls. The real test is to make sure sndPlaySound
> > > doesn't crash, as it does without my patch.
> > 
> > Then the test is completely useless, it actually tests nothing.
> > 
> The ok calls are useless, I guess, but they're not doing any harm,
> either. You can send a patch to remove the ok calls if you like.

Without an ok() call a test is meaningless, I guess that Alexandre committed
it by an accident. Since it's your patch I'll leave a revert to you.


More information about the wine-devel mailing list