[PATCH] winmm: Don't mask out SND_ALIAS_ID or SND_FILENAME in sndPlaySound

Alexandre Julliard julliard at winehq.org
Wed Dec 5 09:38:09 CST 2012

Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Andrew Eikum <aeikum at codeweavers.com> wrote:
>> There is an implied test which is that the tests do not crash. Without
>> the change to <dlls/winmm/playsound.c>, the tests you object to will
>> crash. With the change, they do not crash. This is the behavior being
>> tested.
> I think that Alexandre said several times that the tests for crashes are
> useless. That's one of the reasons why there is no SEH support in the tests.

That's for things that crash on Windows. If it doesn't crash on Windows,
then it's legitimate to test that it also doesn't crash on Wine.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list