[PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

Alexandre Julliard julliard at winehq.org
Thu Dec 6 05:35:41 CST 2012

Alex Henrie <alexhenrie24 at gmail.com> writes:

> 2012/12/5 Alexandre Julliard <julliard at winehq.org>:
>> You have nowhere near enough tests to make such a claim. When I said to
>> write more tests, I didn't mean one or two more. You'd probably need at
>> least 100 tests to have decent coverage of all the interesting cases.
> It's not as much of a technical problem as it is a communication
> problem--I don't know what "interesting cases" you have in mind that
> are not already covered by the tests. Perhaps these cases would be
> obvious to a more experienced developer, but they are not to me.

If you can't think of anything to test beyond the handful of cases you
already have, then you shouldn't be implementing that function. There's
no hope that your code will be able to cope with invalid input if you
can't even imagine what invalid input could look like.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list