msxml3: Add custom handling for DISPID_VALUE for node map

Nikolay Sivov nsivov at codeweavers.com
Thu Dec 20 04:29:49 CST 2012


On 12/19/2012 17:22, Jacek Caban wrote:
> On 12/19/12 08:24, Nikolay Sivov wrote:
>> Add custom handling for DISPID_VALUE for node map
> If this has to be done for all IDispatchEx objects with DISPID_VALUE, it
> may be worth considering changing dispex.c. Something like:
>
> if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD)
>      wFlags |= DISPATCH_PROPERTYGET;
>
> before ITypeInfo::Invoke call should do the trick and replace both this
> patch and already committed node list patch.
So I did more testing and it doesn't work like that for all DISPID_VALUE 
methods, what a surprise:

http://www.winehq.org/pipermail/wine-patches/2012-December/120928.html

Do you think it's still better to centrally change it in dispex.c and 
wrongly accept DISPATCH_METHOD when we shouldn't?
>
> Cheers,
> Jacek




More information about the wine-devel mailing list