new d3d9/device.ok test always fails here, but not a regression?

Austin English austinenglish at gmail.com
Sun Jan 1 20:32:09 CST 2012


On Sat, Dec 31, 2011 at 11:43, Dan Kegel <dank at kegel.com> wrote:
> Happy New Year's Eve, everyone!
>
> 002447357c2b1feca5ef2649429fc55f70238901
> added a IDirect3DDevice9::SetCursorPosition() test to d3d9.
> That test never worked here, I think.  I filed
> http://bugs.winehq.org/show_bug.cgi?id=29094
> for it, and marked it as a regression (since
> tests/device.c used to pass, but fails here
> after that commit).
>
> Henri removed the regression keyword and sha1sum without comment.
>
> What's the reasoning there?  Is Henri saying there's
> something wrong with my test setup (stock ubuntu),
> or are new tests that cause 'make test' to fail not considered regressions?
> Or something else?

That _particular_ test never worked, so it's not a regression. A code
change in d3d itself that broke a previously working test/application
would be a valid regression.

-- 
-Austin



More information about the wine-devel mailing list