PVS-Studio run against ReactOS: (at least) one bug in wine git

[Dan Kegel]

On Sun, Jan 1, 2012 at 10:14 PM, Dan Kegel <dank at kegel.com> wrote:
> Hey, cool!  I added that to http://wiki.winehq.org/StaticAnalysis
>
> I figured I'd try running PVS-Studio on the Wine sources in Wine, but
> it runs in the Visual Studio context, and I can't even load
> the wine project successfully under warn+heap; see
> http://bugs.winehq.org/show_bug.cgi?id=29509
>
> (It'd be awesome if we could build wine with visual studio 2005, not only to use
> it with PVS-Studio, but just for the sake of self-hosting.)

I was able to build a lot of wine on windows with mingw,
and some of wine with visual studio 2005 / 2008,
enough to try running little bits of wine through PVS-Studio's trial.
It found a bunch of 'hr set but not used' and
'pointer not checked for null' kinds of errors.
Might be worth another look once wine is happier building
on windows.  See http://kegel.com/wine/wow.html for
how I went about it.
- Dan