[PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

Alexandre Julliard julliard at winehq.org
Thu Jan 12 08:51:15 CST 2012

Michael Stefaniuc <mstefani at redhat.com> writes:

> Now i would have had different options how to deal with that.
> - Silently drop the test.
> - Dropping the test and documenting why it deviates from the standard test.
> - Adding the test and marking it todo_wine.
> - Add the test and fix the code as the change is trivial.
> I picked IMHO the cleanest solution as that matches native 100% and adds
> a test for that behavior.

In general, not setting something on error doesn't matter, so it doesn't
need to be tested, unless we find an app that depends on it. If you want
to test and replicate the behavior that's OK, but then you don't need to
add comments like "native does this", that's what the tests are for.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list