[PATCH 2/5] ddraw/tests: Port the depth blit test to ddraw7 (try 2)

Stefan Dösinger stefan at codeweavers.com
Mon Jan 23 12:16:50 CST 2012


Am Montag, 23. Januar 2012, 13:47:47 schrieb Henri Verbeet:
> > +    memset(&fx, 0, sizeof(fx));
> > +    fx.dwSize = sizeof(fx);
> > +    fx.dwFillDepth = 0;
> 
> That probably needs an U5(). I tend to forget half of them as well though.
The line is actually redundant. I noticed that when I looked over the other 
tests before sending them, but forgot to remove it from this version. Although 
you could argue that it makes the code more readable - do you have any 
preference before I resend?

@Dan: With things like this one the buildbot could be really helpful. For the 
nameless union issue we don't even need the tests, so we could put the 
buildbot to use before we have all the flakyness bugs solved.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20120123/439d162e/attachment.pgp>


More information about the wine-devel mailing list