[PATCH 1/2] itss: Enlarge buffer to include space for a catenated value.
Jacek Caban
jacek at codeweavers.com
Fri Jan 27 09:56:48 CST 2012
Hi Erich,
On 01/27/12 04:58, Erich E. Hoover wrote:
> --- a/dlls/itss/storage.c
> +++ b/dlls/itss/storage.c
> @@ -418,7 +418,7 @@ static HRESULT WINAPI ITSS_IStorageImpl_OpenStorage(
> if( !chmfile )
> return E_FAIL;
>
> - len = strlenW( This->dir ) + strlenW( pwcsName ) + 1;
> + len = strlenW( This->dir ) + strlenW( pwcsName ) + strlenW( szRoot ) + 1;
szRoot is a constant string, so there is no need to call strlenW on it.
IMO it would be best to get rid of szRoot and use character assignment
instead.
Cheers,
Jacek
More information about the wine-devel
mailing list