[PATCH 2/3] winecoreaudio: Implement the lock-free callback design.

Andrew Eikum aeikum at codeweavers.com
Mon Jan 30 10:13:44 CST 2012


On Mon, Jan 30, 2012 at 11:37:17AM +0100, Joerg-Cyril.Hoehle at t-systems.com wrote:
> Fixes bug #29657
> 

While I like the idea of this patch and how you implemented it, I
wonder if it's appropriate for code freeze.

The main problem in that bug is that the CA driver can deadlock, or
release memory out of order. When working on this patch, were you able
to identify specifically where the contention is? The idea of the
InTransition state was to handle the lock release in mid-call. Can we
add a check for that state in the callbacks to solve this problem less
intrusively?

The first patch seems fine.

Andrew



More information about the wine-devel mailing list