Integer overflow problem in string::compare()

Piotr Caban piotr.caban at gmail.com
Mon Jul 2 04:51:18 CDT 2012


Hi,

On 07/02/12 04:13, Dan Kegel wrote:
> could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ?
> If you like it, I'll submit it to wine-patches.  It passes winetestbot and
> gets pulsen and stepmania past the splash screen abort.
This patch looks correct. It's also good to fix other functions with 
similar bug.

> Why are there no tests for msvcp60?
There's no reason for not having msvcp60 tests. msvcp90 also lacks a lot 
of tests.

> If you think it's appropriate, I can add the fix and test for msvcp60 as well.
It's good to fix it in msvcp60 as well.

Cheers,
Piotr



More information about the wine-devel mailing list