[PATCH 1/8] hhctrl.ocx: Implement HH_CLOSE_ALL.
jacek at codeweavers.com
Mon Jul 9 04:18:01 CDT 2012
On 07/05/12 18:31, Erich E. Hoover wrote:
> On Thu, Jul 5, 2012 at 3:09 AM, Jacek Caban <jacek at codeweavers.com> wrote:
>> While it's not about this particular patch, I can see that you're
>> changing hhctrl.ocx to the point where it has an useful API (as opposed
>> to simple hh.exe-like help viewer). It is really nice to see, thanks. It
>> would be great to have some tests for this. Please consider adding them
>> (I'm sure you already have some code for testing, so I imagine it would
>> be mostly integrating it with Wine test suite).
> Once the get/set HH_WINTYPE commands are in then the only thing that
> remains in order to construct tests is the ability to build CHM files.
> I've been working on trying to get HTML Help Workshop to be able to
> compile CHM files, but so far this endeavor has not met with much
We already have a trivial .chm file in itss tests. It's compiled by HTML
Help Workshop on Windows. You probably could do the same for hhctrl.ocx.
Just make sure others will be able to reproduce the file if needed.
> Did you see anything in these patches that you would like
> changed? I just noticed a double-free mistake, so I'm going to
> resubmit with that fixed when I get a chance and can include any
> suggestions you might have.
Sorry I couldn't get to this sooner. I will review them in a moment.
More information about the wine-devel