[PATCH 1/9] hhctrl.ocx: Implement HH_CLOSE_ALL (resend).

Erich E. Hoover ehoover at mymail.mines.edu
Mon Jul 9 10:49:16 CDT 2012

On Mon, Jul 9, 2012 at 3:31 AM, Jacek Caban <jacek at codeweavers.com> wrote:
> ...
> How is it supposed to work? AFAICS you're destroying windows, removing
> info object from the list and forget about it. If your intention is to
> destroy these objects, then ReleaseHelpViewer seems more appropriate.
> Also moving list_remove call to ReleaseHelpViewer seems preferable, so
> that it's removed from the list regardless of the reason for being
> destroyed. Same for list_add_tail, shouldn't it be done in CreateHelpViewer?

That makes sense, I'll correct this and resubmit.  Is there anything
else you would like me to change?


More information about the wine-devel mailing list