[5/5] gdiplus: Add some tests for GdipBitmapLockBits/GdipBitmapUnlockBits.

Dmitry Timoshkov dmitry at baikal.ru
Wed Jul 11 10:01:57 CDT 2012

Vincent Povirk <madewokherd at gmail.com> wrote:

> Shouldn't your second LockBits in this loop always use
> PixelFormat24bppRGB and ImageLockModeRead? As it is, if the
> LockBits/UnlockBits is writing but not reading, you won't be able to
> tell.

Probably that would simplify the test a bit, but I don't see a problem
with testing the same format.

> Also, you might want to try flags == 0 in some pixel format other than
> 24bppRGB. As I understand it, all modes without
> ImageLockModeUserInputBuf are treated as read+write regardless of
> flags when the bitmap is locked in its native format, as an
> optimization. You may simply be running into that optimization.

Probably, but that's a different case IMO.


More information about the wine-devel mailing list