d3dx9_36: Implementation of D3DXSHRotateZ
matteo.mystral at gmail.com
Wed Jul 18 07:17:05 CDT 2012
2012/7/18 Nozomi Kodama <nozomi.kodama at yahoo.com>:
Minor nitpicks, but nevertheless:
> -@ stub D3DXSHRotateZ(ptr long long ptr)
> +@ stdcall D3DXSHRotateZ(ptr long long ptr)
> +FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in)
I guess using "float" in the spec file for the third parameter would
be more appropriate (yes, it was already wrong but that's not an
+ if ( i >= order * order || ( (order >
D3DXSH_MAXORDER) && ( i >= D3DXSH_MAXORDER * D3DXSH_MAXORDER ) ) )
+ expected = ( i + 1.0f ) * ( i + 1.0f );
In general the inner for loop in the tests feels awkward, try to
rewrite it to avoid the duplicated stuff.
You're adding a tab character here, please use only whitespaces for indentation.
That said, thanks for your work on d3dx9!
More information about the wine-devel