[1/2] gdiplus: Don't keep a reference to HDC in the GpBitmap object.

Dmitry Timoshkov dmitry at baikal.ru
Fri Jul 27 10:15:25 CDT 2012


Vincent Povirk <madewokherd at gmail.com> wrote:

> You're adding a test that relies on a corner case that should be
> regarded as a broken program, and that could easily result in a
> use-after-free on native. I'm not convinced this is reliable, as the
> native codepath could involve a use-after-free and still work by
> coincidence. There is no evidence that any real program relies on this
> case, and you could easily modify your test to not depend on it.

Do you have any proof that "it's a corner case and is not reliable"?
The test passes for me in any number of runs and test sequences under
32-bit bit XP and as 32 or 64-bit executable under 64-bit Win7.

-- 
Dmitry.



More information about the wine-devel mailing list