[PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry at baikal.ru> writes:

>> Have you actually tested it with characters 32-pixel wide, and confirmed
>> that Windows messes them up the same way?
>
> What I have done is a comparison of screenshots of the affected application
> produced under Windows and Wine. If there will be a need in futher improvements
> I'll certainly have a look what can be enhanced.

Once again, have you explicitly tested 32-pixel wide characters?
Obviously other sizes won't show the problem.

>> > Besides,
>> > status of the patches was New, both for the test and this implementation.
>> 
>> What has this got to do with anything? If your patch receives comments
>> you have to address them, I'm not going to review it if someone else
>> already did.
>
> Shouldn't the patch status reflect that? Or commenting on a patch automatically
> makes it rejected?

It may or may not, depending on how you address the comments. Usually it
would become superseded once you send a fixed version.

-- 
Alexandre Julliard
julliard at winehq.org