oleaut32: Add a test for BSTR cache. Take 3.

Alexandre Julliard julliard at winehq.org
Tue Jun 5 06:34:32 CDT 2012


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>
>> That doesn't seem very useful. What use case would there be for an app
>> to rely on some random 75% of its strings to remain valid?
>
> Although the test is about statistics, my intention was to show that BSTR
> cache in Wine corrupts cached strings. I could try to figure out exact
> steps which lead to corruption of real strings the application cares
> about, but that's pretty hard to do, there are enourmous amount of lines in
> the log that are related to BSTR creation/destruction, and finally the string
> the app cares about and tries to use is corrupted. I thought that adding
> a statistical test would hint Jacek what might be wrong with current cache
> implementation.

Any cache is going to reuse space sooner or later, that doesn't mean
there's something wrong with it. If an app relies on a specific string
not being reused, we need a test for that exact allocation pattern so
that we can make sure our cache works the same way for that case.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list